On Sat, 2008-01-19 at 09:13 +0100, Ingo Molnar wrote:
> * Harvey Harrison <[EMAIL PROTECTED]> wrote:
>
> > #ifdef CONFIG_X86_32
> > - "%s%s[%d]: segfault at %lx ip %08lx sp %08lx error
> > %lx\n",
> > + "%s%s[%d]: segfault at %lx ip %08lx sp %08lx error %lx",
> > #else
>
> > #ifdef CONFIG_X86_32
> > - "%s%s[%d]: segfault at %08lx ip %08lx sp %08lx error
> > %lx\n",
> > + "%s%s[%d]: segfault at %lx ip %08lx sp %08lx error %lx",
> > #else
>
> thanks, applied.
>
> Ingo
I'm just looking at some of the other printks in do+page_fault right
now in the oops code.
What do you prefer:
"Unable to handle kernel NULL pointer dereference"
or
"BUG: unable to handle kernel NULL pointer dereference"
Other than that, I think for the most part, the shorter X86_64 strings
are better.
This does change user-visible output however, but would be nice to have
a similar format.
Harvey
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
