On Thu, 1 Apr 2021, Beatriz Martins de Carvalho wrote:
> Cleans up check of "Lines should not end with a '('"
> with argument present in next line in file emxx_udc.c
The coding style documentation encourages remaining within 80 characters.
I'm not sure that the ( warning is worth increading the excess beyond 80
characters (or introducing it in the last case).
julia
>
> Signed-off-by: Beatriz Martins de Carvalho
> <martinsdecarvalhobeat...@gmail.com>
> ---
> drivers/staging/emxx_udc/emxx_udc.c | 11 ++++-------
> 1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/staging/emxx_udc/emxx_udc.c
> b/drivers/staging/emxx_udc/emxx_udc.c
> index 741147a4f0fe..20f53cf6e20f 100644
> --- a/drivers/staging/emxx_udc/emxx_udc.c
> +++ b/drivers/staging/emxx_udc/emxx_udc.c
> @@ -1073,9 +1073,8 @@ static int _nbu2ss_epn_in_pio(struct nbu2ss_udc *udc,
> struct nbu2ss_ep *ep,
> i_word_length = length / sizeof(u32);
> if (i_word_length > 0) {
> for (i = 0; i < i_word_length; i++) {
> - _nbu2ss_writel(
> - &preg->EP_REGS[ep->epnum - 1].EP_WRITE,
> - p_buf_32->dw);
> + _nbu2ss_writel(&preg->EP_REGS[ep->epnum -
> 1].EP_WRITE,
> + p_buf_32->dw);
>
> p_buf_32++;
> }
> @@ -1225,8 +1224,7 @@ static void _nbu2ss_restert_transfer(struct nbu2ss_ep
> *ep)
> return;
>
> if (ep->epnum > 0) {
> - length = _nbu2ss_readl(
> - &ep->udc->p_regs->EP_REGS[ep->epnum - 1].EP_LEN_DCNT);
> + length = _nbu2ss_readl(&ep->udc->p_regs->EP_REGS[ep->epnum -
> 1].EP_LEN_DCNT);
>
> length &= EPN_LDATA;
> if (length < ep->ep.maxpacket)
> @@ -1462,8 +1460,7 @@ static void _nbu2ss_epn_set_stall(struct nbu2ss_udc
> *udc,
> for (limit_cnt = 0
> ; limit_cnt < IN_DATA_EMPTY_COUNT
> ; limit_cnt++) {
> - regdata = _nbu2ss_readl(
> - &preg->EP_REGS[ep->epnum - 1].EP_STATUS);
> + regdata = _nbu2ss_readl(&preg->EP_REGS[ep->epnum -
> 1].EP_STATUS);
>
> if ((regdata & EPN_IN_DATA) == 0)
> break;
> --
> 2.25.1
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/outreachy-kernel/20210401195457.24512-1-martinsdecarvalhobeatriz%40gmail.com.
>
