Hi Ricardo,
On Fri, Mar 26, 2021 at 7:00 PM Ricardo Ribalda <riba...@chromium.org> wrote:
>
> From: Hans Verkuil <hverk...@xs4all.nl>
>
> When uvc was written the vb2 ioctl and file operation helpers didn't exist.
>
> This patch switches uvc over to those helpers, which removes a lot of
> boilerplate
> code and simplifies VIDIOC_G/S_PRIORITY handling and allows us to drop the
> 'privileges' scheme, since that's now handled inside the vb2 helpers.
>
> This makes it possible for uvc to pass the v4l2-compliance streaming tests.
>
> Signed-off-by: Hans Verkuil <hverkuil-ci...@xs4all.nl>
Thanks for the patch. Did you perhaps miss adding your sign-off?
Also, see my comments inline.
[snip]
> @@ -1166,11 +969,6 @@ static int uvc_ioctl_s_parm(struct file *file, void *fh,
> {
> struct uvc_fh *handle = fh;
> struct uvc_streaming *stream = handle->stream;
> - int ret;
> -
> - ret = uvc_acquire_privileges(handle);
> - if (ret < 0)
> - return ret;
Why is it okay not to acquire the privileges here?
>
> return uvc_v4l2_set_streamparm(stream, parm);
> }
Best regards,
Tomasz
