On Fri, Apr 02, 2021 at 08:43:24PM +0300, Andy Shevchenko wrote: > The series contains set of clean ups, main parts of which are: > - use ne platform_get_mem_or_io() API > - use match_string() API
As I have already said, a very nice set of cleanups. Thank you. These are applied and in the ipmi linux-next tree. -corey > > Since v2: > - patch 3: rephrased commit message (Corey) > - patch 5: added a comment that array maps to enum (Corey) > - patch 5: added "ipmi" prefix to the name of the array > - patch 6: just exported array w/o moving to header (Corey) > - wrapped up cover letter > > Andy Shevchenko (10): > ipmi_si: Switch to use platform_get_mem_or_io() > ipmi_si: Remove bogus err_free label > ipmi_si: Utilize temporary variable to hold device pointer > ipmi_si: Use proper ACPI macros to check error code for failures > ipmi_si: Introduce ipmi_panic_event_str[] array > ipmi_si: Reuse si_to_str[] array in ipmi_hardcode_init_one() > ipmi_si: Get rid of ->addr_source_cleanup() > ipmi_si: Use strstrip() to remove surrounding spaces > ipmi_si: Drop redundant check before calling put_device() > ipmi_si: Join string literals back > > drivers/char/ipmi/ipmi_msghandler.c | 54 ++++++---------- > drivers/char/ipmi/ipmi_si.h | 8 ++- > drivers/char/ipmi/ipmi_si_hardcode.c | 73 ++++++++------------- > drivers/char/ipmi/ipmi_si_hotmod.c | 24 ++----- > drivers/char/ipmi/ipmi_si_intf.c | 32 ++++------ > drivers/char/ipmi/ipmi_si_pci.c | 22 ++----- > drivers/char/ipmi/ipmi_si_platform.c | 95 ++++++++++++---------------- > 7 files changed, 112 insertions(+), 196 deletions(-) > > -- > 2.30.2 >
