Re: [PATCH v3 23/30] staging: rtl8723bs: fix comparison in if condition in core/rtw_recv.c

[Joe Perches]

On Sat, 2021-04-03 at 11:13 +0200, Fabio Aiuto wrote:
> fix post-commit checkpatch issue:
> 
> CHECK: Using comparison to false is error prone
> 27: FILE: drivers/staging/rtl8723bs/core/rtw_recv.c:381:
> +                             if (psecuritypriv->
>                       bcheck_grpkey == false &&
> 
> Signed-off-by: Fabio Aiuto <fabioaiut...@gmail.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_recv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c 
> b/drivers/staging/rtl8723bs/core/rtw_recv.c
> index cd4324a93275..21949925ec77 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_recv.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
> @@ -378,7 +378,7 @@ static signed int recvframe_chkmic(struct adapter 
> *adapter,  union recv_frame *p
>  
> 
>                       } else {
>                               /* mic checked ok */
> -                             if (psecuritypriv->bcheck_grpkey == false &&
> +                             if (!psecuritypriv->bcheck_grpkey &&
>                                   (IS_MCAST(prxattrib->ra) == true))
>                                       psecuritypriv->bcheck_grpkey = true;
>                       }