On Sat, 3 Apr 2021, Deborah Brouwer wrote:
> To conform with Linux kernel coding style, replace goto statement that
> does no cleanup with a direct return. To preserve meaning, copy comments
> from the original goto statement to the return statement. Identified by
> the checkpatch warning: WARNING: void function return statements are not
> generally useful.
Maybe the comments are meant as TODO items?
julia
>
> Signed-off-by: Deborah Brouwer <deborahbrouwer3...@gmail.com>
> ---
> drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
> b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
> index 391c59490718..d21f21857c20 100644
> --- a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
> +++ b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
> @@ -139,7 +139,9 @@ void rtw_hal_dm_watchdog(struct adapter *Adapter)
> hw_init_completed = Adapter->hw_init_completed;
>
> if (!hw_init_completed)
> - goto skip_dm;
> + /* Check GPIO to determine current RF on/off and Pbc status. */
> + /* Check Hardware Radio ON/OFF or not */
> + return;
>
> /* ODM */
> pmlmepriv = &Adapter->mlmepriv;
> @@ -156,10 +158,8 @@ void rtw_hal_dm_watchdog(struct adapter *Adapter)
>
> Adapter->HalData->odmpriv.bLinked = bLinked;
> ODM_DMWatchdog(&Adapter->HalData->odmpriv);
> -skip_dm:
> /* Check GPIO to determine current RF on/off and Pbc status. */
> /* Check Hardware Radio ON/OFF or not */
> - return;
> }
>
> void rtw_hal_dm_init(struct adapter *Adapter)
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/outreachy-kernel/20210404054008.23525-1-deborahbrouwer3563%40gmail.com.
>
