Hi Doug, Thank you for the patch.
On Fri, Apr 02, 2021 at 03:28:40PM -0700, Douglas Anderson wrote: > If we just leave the detect() function as NULL then the upper layers > assume we're always connected. There's no reason for a stub. > > Signed-off-by: Douglas Anderson <diand...@chromium.org> > Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > --- > > (no changes since v1) > > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 12 ------------ > 1 file changed, 12 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c > b/drivers/gpu/drm/bridge/ti-sn65dsi86.c > index e30460002c48..51db30d573c1 100644 > --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c > +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c > @@ -306,20 +306,8 @@ static struct drm_connector_helper_funcs > ti_sn_bridge_connector_helper_funcs = { > .mode_valid = ti_sn_bridge_connector_mode_valid, > }; > > -static enum drm_connector_status > -ti_sn_bridge_connector_detect(struct drm_connector *connector, bool force) > -{ > - /** > - * TODO: Currently if drm_panel is present, then always > - * return the status as connected. Need to add support to detect > - * device state for hot pluggable scenarios. > - */ > - return connector_status_connected; > -} > - > static const struct drm_connector_funcs ti_sn_bridge_connector_funcs = { > .fill_modes = drm_helper_probe_single_connector_modes, > - .detect = ti_sn_bridge_connector_detect, > .destroy = drm_connector_cleanup, > .reset = drm_atomic_helper_connector_reset, > .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state, -- Regards, Laurent Pinchart