>>> Greg KH <[EMAIL PROTECTED]> 19.01.08 02:28 >>> >On Fri, Jan 11, 2008 at 01:57:27AM -0700, Jan Beulich wrote: >> The drivers picked just serve as examples (which I routinely build and >> hence am able to easily verify), i.e. as before he patch doesn't change >> all instances where 'const' could have been added as a result of the >> base change, only where the change has a real effect (the module loader >> doesn't enforce read-only section attributes at present, so only >> built-in files make a real difference). > >What does this buy us?
Not sure what part the question applies to... >> --- 2.6.24-rc7-initconst.orig/include/linux/init.h >> +++ 2.6.24-rc7-initconst/include/linux/init.h >> @@ -257,11 +257,13 @@ void __init parse_early_param(void); >> #ifdef CONFIG_HOTPLUG >> #define __devinit >> #define __devinitdata >> +#define __devinitconst const >> #define __devexit >> #define __devexitdata >> #else >> #define __devinit __init >> #define __devinitdata __initdata >> +#define __devinitconst __initdata > >Shoudn't that be "__initdata const" or something like that? No, specifically not, as otherwise this will report in 'section type conflict' compiler (or assembler?) warnings. But Sam's concept addresses this in a neater way anyway, so my current take is that I'll resubmit any parts needed after he's got his patch in. Jan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/