On 4/7/21 10:03 AM, Andy Shevchenko wrote: > On Wed, Apr 07, 2021 at 11:51:31PM +0800, kernel test robot wrote: >> Hi Andy, >> >> I love your patch! Yet something to improve: >> >> [auto build test ERROR on block/for-next] >> [also build test ERROR on v5.12-rc6 next-20210407] >> [If your patch is applied to the wrong git tree, kindly drop us a note. >> And when submitting patch, we suggest to use '--base' as documented in >> https://git-scm.com/docs/git-format-patch] >> >> url: >> https://github.com/0day-ci/linux/commits/Andy-Shevchenko/ata-Drop-unneeded-inclusion-of-kernel-h-in-the-header/20210407-214746 >> base: >> https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git >> for-next >> config: x86_64-randconfig-s021-20210407 (attached as .config) >> compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 >> reproduce: >> # apt-get install sparse >> # sparse version: v0.6.3-279-g6d5d9b42-dirty >> # >> https://github.com/0day-ci/linux/commit/d2574103b692b4fc73f1ed36ee9e4d3324902fd9 >> git remote add linux-review https://github.com/0day-ci/linux >> git fetch --no-tags linux-review >> Andy-Shevchenko/ata-Drop-unneeded-inclusion-of-kernel-h-in-the-header/20210407-214746 >> git checkout d2574103b692b4fc73f1ed36ee9e4d3324902fd9 >> # save the attached .config to linux build tree >> make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64 >> >> If you fix the issue, kindly add following tag as appropriate >> Reported-by: kernel test robot <l...@intel.com> >> >> All errors (new ones prefixed by >>): > > Thanks, we need to include bits.h. > (It passed my simple build, but appears I have no such driver included) > > Jens, I saw your message, should I send a follow up fix, or a v2?
Let's just drop it, not worth it for the risk imho. -- Jens Axboe
