On Wed, Apr 07, 2021 at 06:30:00PM +0200, Fabio M. De Francesco wrote: > Remove camelcase. Issue detected by checkpatch.pl. For now, change only > names of static functions in order to not break the driver's code. > > Signed-off-by: Fabio M. De Francesco <[email protected]> > --- > drivers/staging/rtl8723bs/hal/sdio_ops.c | 44 ++++++++++++------------ > 1 file changed, 22 insertions(+), 22 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c > b/drivers/staging/rtl8723bs/hal/sdio_ops.c > index b1f02bb9f0a9..5e28818e58e0 100644 > --- a/drivers/staging/rtl8723bs/hal/sdio_ops.c > +++ b/drivers/staging/rtl8723bs/hal/sdio_ops.c > @@ -19,7 +19,7 @@ > /* */ > /* Creadted by Roger, 2011.01.31. */ > /* */ > -static void HalSdioGetCmdAddr8723BSdio( > +static void hal_sdio_get_cmd_addr_8723b_sdio( > struct adapter *adapter, > u8 device_id, > u32 addr, > @@ -97,7 +97,7 @@ static u8 get_deviceid(u32 addr) > > /* > * Ref: > - *HalSdioGetCmdAddr8723BSdio() > + *hal_sdio_get_cmd_addr_8723b_sdio()
What does this comment even mean? I think you can delete it. But really, that's a crazy function name length, can you make it any shorter? thanks, greg k-h
