When v4l2_subdev_call() fails, a pairing PM usage counter
decrement is needed to keep the counter balanced. It's the
same for the following error paths in case 'enable' is on.

Signed-off-by: Dinghao Liu <dinghao....@zju.edu.cn>
---
 drivers/staging/media/imx/imx7-mipi-csis.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c 
b/drivers/staging/media/imx/imx7-mipi-csis.c
index a01a7364b4b9..2a3fff231a40 100644
--- a/drivers/staging/media/imx/imx7-mipi-csis.c
+++ b/drivers/staging/media/imx/imx7-mipi-csis.c
@@ -627,21 +627,26 @@ static int mipi_csis_s_stream(struct v4l2_subdev 
*mipi_sd, int enable)
                        return ret;
                }
                ret = v4l2_subdev_call(state->src_sd, core, s_power, 1);
-               if (ret < 0)
+               if (ret < 0) {
+                       pm_runtime_put_noidle(&state->pdev->dev);
                        return ret;
+               }
        }
 
        mutex_lock(&state->lock);
        if (enable) {
                if (state->flags & ST_SUSPENDED) {
                        ret = -EBUSY;
+                       pm_runtime_put_noidle(&state->pdev->dev);
                        goto unlock;
                }
 
                mipi_csis_start_stream(state);
                ret = v4l2_subdev_call(state->src_sd, video, s_stream, 1);
-               if (ret < 0)
+               if (ret < 0) {
+                       pm_runtime_put_noidle(&state->pdev->dev);
                        goto unlock;
+               }
 
                mipi_csis_log_counters(state, true);
 
-- 
2.17.1

Reply via email to