On Thu, Apr 08, 2021 at 11:10:38AM +0200, Hans de Goede wrote:
> Hi,
>
> On 4/7/21 11:15 AM, Zhen Lei wrote:
> > Fixes the following W=1 kernel build warning:
> >
> > drivers/usb/typec/tcpm/tcpm.c:2107:39: warning: ‘tcpm_altmode_ops’ defined
> > but not used [-Wunused-const-variable=]
> >
> > The reference to the variable 'tcpm_altmode_ops' is deleted by the
> > commit a079973f462a ("usb: typec: tcpm: Remove tcpc_config configuration
> > mechanism").
> >
> > By the way, the static functions referenced only by the variable
> > 'tcpm_altmode_ops' are deleted accordingly.
> >
> > Reported-by: Hulk Robot <hul...@huawei.com>
> > Signed-off-by: Zhen Lei <thunder.leiz...@huawei.com>
>
> I have a patch pending:
>
> https://www.spinics.net/lists/linux-usb/msg197684.html
>
> Which actually uses this. I really need to (and plan to) brush the dust of
> this one soon and submit a new version.
>
> As such I would prefer for these ops to not get removed. But I guess I
> can always include a patch in my series reverting the removal...
Well, can we then just leave the ops there? If we're going to
re-introduce them back soon in any case, then why drop them in the
first place.
thanks,
--
heikki
