On Tue, Jan 22, 2008 at 05:25:38PM +0100, Peter Zijlstra wrote:
> @@ -1428,9 +1428,9 @@ static void print_cfs_stats(struct seq_f
>  #ifdef CONFIG_FAIR_GROUP_SCHED
>       print_cfs_rq(m, cpu, &cpu_rq(cpu)->cfs);
>  #endif
> -     lock_task_group_list();
> +     rcu_read_lock();
>       for_each_leaf_cfs_rq(cpu_rq(cpu), cfs_rq)
>               print_cfs_rq(m, cpu, cfs_rq);

Isn't there a possibility that print_cfs_rq() can block?

> -     unlock_task_group_list();
> +     rcu_read_unlock();
>  }
>  #endif
> 

-- 
Regards,
vatsa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to