Am 01.04.21 um 03:59 schrieb Bernard:
From: "Christian König" <christian.koe...@amd.com>
Date: 2021-03-31 21:15:22
To: Bernard Zhao <bern...@vivo.com>,Huang Rui <ray.hu...@amd.com>,David Airlie
<airl...@linux.ie>,Daniel Vetter
<dan...@ffwll.ch>,dri-de...@lists.freedesktop.org,linux-kernel@vger.kernel.org
Cc: opensource.ker...@vivo.com
Subject: Re: [PATCH] drm/ttm: cleanup coding style a bit>Am 31.03.21 um 15:12
schrieb Bernard Zhao:
Fix sparse warning:
drivers/gpu/drm/ttm/ttm_bo.c:52:1: warning: symbol 'ttm_global_mutex' was not
declared. Should it be static?
drivers/gpu/drm/ttm/ttm_bo.c:53:10: warning: symbol 'ttm_bo_glob_use_count' was
not declared. Should it be static?
Signed-off-by: Bernard Zhao <bern...@vivo.com>
You are based on an outdated branch, please rebase on top of drm-misc-next.
Hi
Sure, thanks for your review！
I will fix this and resubmit this patch.
Found some time today to do it myself. Please review the patch I've just
send to you.
Thanks,
Christian.
BR//Bernard
Regards,
Christian.
---
drivers/gpu/drm/ttm/ttm_bo.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
index 101a68dc615b..eab21643edfb 100644
--- a/drivers/gpu/drm/ttm/ttm_bo.c
+++ b/drivers/gpu/drm/ttm/ttm_bo.c
@@ -49,8 +49,8 @@ static void ttm_bo_global_kobj_release(struct kobject *kobj);
/*
* ttm_global_mutex - protecting the global BO state
*/
-DEFINE_MUTEX(ttm_global_mutex);
-unsigned ttm_bo_glob_use_count;
+static DEFINE_MUTEX(ttm_global_mutex);
+static unsigned int ttm_bo_glob_use_count;
struct ttm_bo_global ttm_bo_glob;
EXPORT_SYMBOL(ttm_bo_glob);
