On Sat, Apr 10, 2021 at 11:09:19AM +0200, Bartosz Golaszewski wrote: > From: Andy Shevchenko <[email protected]> > > On STM32MP1, the GPIO banks are subnodes of pin-controller@50002000, > see arch/arm/boot/dts/stm32mp151.dtsi. The driver for > pin-controller@50002000 is in drivers/pinctrl/stm32/pinctrl-stm32.c > and iterates over all of its DT subnodes when registering each GPIO > bank gpiochip. Each gpiochip has: > > - gpio_chip.parent = dev, > where dev is the device node of the pin controller > - gpio_chip.of_node = np, > which is the OF node of the GPIO bank > > Therefore, dev_fwnode(chip->parent) != of_fwnode_handle(chip.of_node), > i.e. pin-controller@50002000 != pin-controller@50002000/gpio@5000*000. > > The original code behaved correctly, as it extracted the "gpio-line-names" > from of_fwnode_handle(chip.of_node) = pin-controller@50002000/gpio@5000*000. > > To achieve the same behaviour, read property from the firmware node. > > Fixes: 7cba1a4d5e162 ("gpiolib: generalize devprop_gpiochip_set_names() for > device properties") > Cc: [email protected] > Reported-by: Marek Vasut <[email protected]> > Reported-by: Roman Guskov <[email protected]> > Signed-off-by: Andy Shevchenko <[email protected]> > Tested-by: Marek Vasut <[email protected]> > Reviewed-by: Marek Vasut <[email protected]> > Signed-off-by: Bartosz Golaszewski <[email protected]> > --- > Hi Greg, > > This patch somehow got lost and never made its way into stable. Could you > please apply it?
This has been added and removed more times than I can remember already. Are you all _SURE_ this is safe for a stable kernel release? Look in the archives for complaints when we added this in the past. thanks, greg k-h
