On Tue, Jan 22, 2008 at 02:28:08PM +0000, Ian Abbott wrote: > #include <linux/init.h> > #include <linux/string.h> > #include <linux/slab.h> > +#include <linux/workqueue.h> > #include "../pci.h" > #if !defined(MODULE) > @@ -63,10 +64,13 @@ struct dummy_slot { > struct list_head node; > struct hotplug_slot *slot; > struct pci_dev *dev; > + struct work_struct remove_work; > + unsigned long removed;
You are treating "removed" as an atomic value, so why not just make it an atomic_t? And what is protecting the fact that the flag could be set right after it gets checked? I don't see a lock here :) thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/