On 4/12/21 5:29 PM, Oscar Salvador wrote: > On Thu, Apr 01, 2021 at 12:14:06PM +0530, Anshuman Khandual wrote: >> ARCH_ENABLE_[HUGEPAGE|THP]_MIGRATION configs have duplicate definitions on >> platforms that subscribe them. Drop these reduntant definitions and instead >> just select them appropriately. >> >> Cc: Catalin Marinas <catalin.mari...@arm.com> >> Cc: Will Deacon <w...@kernel.org> >> Cc: Michael Ellerman <m...@ellerman.id.au> >> Cc: Benjamin Herrenschmidt <b...@kernel.crashing.org> >> Cc: Paul Mackerras <pau...@samba.org> >> Cc: Thomas Gleixner <t...@linutronix.de> >> Cc: Ingo Molnar <mi...@redhat.com> >> Cc: "H. Peter Anvin" <h...@zytor.com> >> Cc: Andrew Morton <a...@linux-foundation.org> >> Cc: x...@kernel.org >> Cc: linux-arm-ker...@lists.infradead.org >> Cc: linuxppc-...@lists.ozlabs.org >> Cc: linux...@kvack.org >> Cc: linux-kernel@vger.kernel.org >> Acked-by: Catalin Marinas <catalin.mari...@arm.com> (arm64) >> Signed-off-by: Anshuman Khandual <anshuman.khand...@arm.com> > > Hi Anshuman, > > X86 needs fixing, see below: > >> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig >> index 503d8b2e8676..10702ef1eb57 100644 >> --- a/arch/x86/Kconfig >> +++ b/arch/x86/Kconfig >> @@ -60,8 +60,10 @@ config X86 >> select ACPI_SYSTEM_POWER_STATES_SUPPORT if ACPI >> select ARCH_32BIT_OFF_T if X86_32 >> select ARCH_CLOCKSOURCE_INIT >> + select ARCH_ENABLE_HUGEPAGE_MIGRATION if x86_64 && HUGETLB_PAGE && >> MIGRATION >> select ARCH_ENABLE_MEMORY_HOTPLUG if X86_64 || (X86_32 && HIGHMEM) >> select ARCH_ENABLE_MEMORY_HOTREMOVE if MEMORY_HOTPLUG >> + select ARCH_ENABLE_THP_MIGRATION if x86_64 && TRANSPARENT_HUGEPAGE > > you need s/x86_64/X86_64/, otherwise we are left with no migration :-)
Ahh, right. I guess this could not have got detected during a build test. As the series is in mmotm tree, wondering if Andrew could help fix these typos in this patch.
