On Tue 13-04-21 14:51:53, Muchun Song wrote:
> The noinline_for_stack is introduced by commit 666356297ec4 ("vmscan:
> set up pagevec as late as possible in shrink_inactive_list()"), its
> purpose is to delay the allocation of pagevec as late as possible to
> save stack memory. But the commit 2bcf88796381 ("mm: take pagevecs off
> reclaim stack") replace pagevecs by lists of pages_to_free. So we do
> not need noinline_for_stack, just remove it (let the compiler decide
> whether to inline).
>
> Signed-off-by: Muchun Song <[email protected]>
> Acked-by: Johannes Weiner <[email protected]>
> Acked-by: Roman Gushchin <[email protected]>
> Reviewed-by: Shakeel Butt <[email protected]>Acked-by: Michal Hocko <[email protected]> > --- > mm/vmscan.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 64bf07cc20f2..e40b21298d77 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -2015,8 +2015,8 @@ static int too_many_isolated(struct pglist_data *pgdat, > int file, > * > * Returns the number of pages moved to the given lruvec. > */ > -static unsigned noinline_for_stack move_pages_to_lru(struct lruvec *lruvec, > - struct list_head *list) > +static unsigned int move_pages_to_lru(struct lruvec *lruvec, > + struct list_head *list) > { > int nr_pages, nr_moved = 0; > LIST_HEAD(pages_to_free); > @@ -2096,7 +2096,7 @@ static int current_may_throttle(void) > * shrink_inactive_list() is a helper for shrink_node(). It returns the > number > * of reclaimed pages > */ > -static noinline_for_stack unsigned long > +static unsigned long > shrink_inactive_list(unsigned long nr_to_scan, struct lruvec *lruvec, > struct scan_control *sc, enum lru_list lru) > { > -- > 2.11.0 -- Michal Hocko SUSE Labs
