Hi Rob,
Please find my response inline.
> -----Original Message-----
> From: Rob Herring <[email protected]>
> Sent: Wednesday, March 10, 2021 10:50 PM
> To: Nava kishore Manne <[email protected]>
> Cc: [email protected]; [email protected]; Michal Simek <[email protected]>;
> [email protected]; Jolly Shah <[email protected]>; Rajan Vaja
> <[email protected]>; [email protected]; Manish Narani
> <[email protected]>; Amit Sunil Dhamne <[email protected]>; Tejas
> Patel <[email protected]>; [email protected];
> [email protected]; [email protected]; linux-arm-
> [email protected]; [email protected]; Appana Durga
> Kedareswara Rao <[email protected]>
> Subject: Re: [PATCH v3 2/3] dt-bindings: fpga: Add binding doc for versal fpga
> manager
>
> On Wed, Mar 10, 2021 at 10:12 AM Rob Herring <[email protected]> wrote:
> >
> > On Wed, Mar 10, 2021 at 3:50 AM Nava kishore Manne
> <[email protected]> wrote:
> > >
> > > Hi Rob,
> > >
> > > Thanks for providing the review comments.
> > > Please find my response inline.
> > >
> > > > -----Original Message-----
> > > > From: Rob Herring <[email protected]>
> > > > Sent: Tuesday, March 9, 2021 1:50 AM
> > > > To: Nava kishore Manne <[email protected]>
> > > > Cc: [email protected]; [email protected]; Michal Simek
> > > > <[email protected]>; [email protected]; Jolly Shah
> > > > <[email protected]>; Rajan Vaja <[email protected]>;
> > > > [email protected]; Manish Narani <[email protected]>; Amit Sunil
> > > > Dhamne <[email protected]>; Tejas Patel
> > > > <[email protected]>; [email protected];
> > > > [email protected]; [email protected];
> > > > linux-arm- [email protected]; [email protected];
> > > > Appana Durga Kedareswara Rao <[email protected]>
> > > > Subject: Re: [PATCH v3 2/3] dt-bindings: fpga: Add binding doc for
> > > > versal fpga manager
> > > >
> > > > On Thu, Mar 04, 2021 at 12:32:23PM +0530, Nava kishore Manne
> wrote:
> > > > > From: Appana Durga Kedareswara rao
> <[email protected]>
> > > > >
> > > > > This patch adds binding doc for versal fpga manager driver.
> > > >
> > > > Why do you need a DT entry for this? Can't the Versal firmware
> > > > driver instantiate the fpga-mgr device?
> > > >
> > > This dt entry is need to handle the fpga regions properly for both full
> > > and
> Partial bitstream loading use cases and it cannot be done by Versal firmware
> driver instantiate.
> >
> > Ah yes, I forgot about that.
>
> Looking at this some more, please convert xlnx,zynqmp-firmware.txt to
> schema and add the node for this there. We don't need a whole other
> schema file just for a node and compatible. Also, looks like xlnx,zynqmp-
> pcap-fpga.txt is the prior version of the same thing, so it should be handled
> in the schema too.
>
Will fix this in the next version
Regards,
Navakishore.
