On Thu, Apr 15 2021 at 12:39, Marcelo Tosatti wrote: > +static bool need_reprogram_timer(struct hrtimer_cpu_base *cpu_base) > +{ > + unsigned int active = 0; > + > + if (cpu_base->softirq_activated) > + return true; > + > + active = cpu_base->active_bases & HRTIMER_ACTIVE_SOFT; > + active = active | (cpu_base->active_bases & HRTIMER_ACTIVE_HARD);
It's not entirely clear to me what that 'active' variable business above is doing and why it's needed at all. But I might be missing something. > + return (cpu_base->active_bases & CLOCK_SET_BASES) != 0; > +}