On Sun, 4 Apr 2021 at 06:34, <[email protected]> wrote: > > From: Guangqing Zhu <[email protected]> > > Fixes coccicheck error: > > drivers/thermal/qcom/tsens.c:759:4-10: ERROR: missing put_device; call > of_find_device_by_node on line 715, but without a corresponding object > release within this function. > > Fixes: a7ff82976122 ("drivers: thermal: tsens: Merge tsens-common.c into > tsens.c") > > Signed-off-by: Guangqing Zhu <[email protected]> > --- > drivers/thermal/qcom/tsens.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c > index d8ce3a687b80..cc4c6a9853a4 100644 > --- a/drivers/thermal/qcom/tsens.c > +++ b/drivers/thermal/qcom/tsens.c > @@ -755,9 +755,10 @@ int __init init_common(struct tsens_priv *priv) > for (i = VER_MAJOR; i <= VER_STEP; i++) { > priv->rf[i] = devm_regmap_field_alloc(dev, > priv->srot_map, > > priv->fields[i]); > - if (IS_ERR(priv->rf[i])) > - return PTR_ERR(priv->rf[i]); > - } > + if (IS_ERR(priv->rf[i])) { > + ret = PTR_ERR(priv->rf[i]); > + goto err_put_device; > + }
As kbuild robot pointed out - this does not even compile. Please at least build all your patches before sending. Best regards, Krzysztof
