Hi Faiyaz, Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master] [also build test ERROR on v5.12-rc7] [cannot apply to hnaz-linux-mm/master next-20210416] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Faiyaz-Mohammed/mm-slub-move-sysfs-slab-alloc-free-interfaces-to-debugfs/20210416-222940 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 7e25f40eab52c57ff6772d27d2aef3640a3237d7 config: mips-randconfig-r001-20210416 (attached as .config) compiler: mips64el-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/8adf70f166344443e2f4e689e30c5d20f16b234e git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Faiyaz-Mohammed/mm-slub-move-sysfs-slab-alloc-free-interfaces-to-debugfs/20210416-222940 git checkout 8adf70f166344443e2f4e689e30c5d20f16b234e # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=mips If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> All errors (new ones prefixed by >>): mm/slab_common.c: In function 'slab_caches_to_rcu_destroy_workfn': >> mm/slab_common.c:441:3: error: implicit declaration of function >> 'debugfs_slab_release' [-Werror=implicit-function-declaration] 441 | debugfs_slab_release(s); | ^~~~~~~~~~~~~~~~~~~~ At top level: mm/slab_common.c:1124:30: warning: 'slabinfo_proc_ops' defined but not used [-Wunused-const-variable=] 1124 | static const struct proc_ops slabinfo_proc_ops = { | ^~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +/debugfs_slab_release +441 mm/slab_common.c 409 410 static void slab_caches_to_rcu_destroy_workfn(struct work_struct *work) 411 { 412 LIST_HEAD(to_destroy); 413 struct kmem_cache *s, *s2; 414 415 /* 416 * On destruction, SLAB_TYPESAFE_BY_RCU kmem_caches are put on the 417 * @slab_caches_to_rcu_destroy list. The slab pages are freed 418 * through RCU and the associated kmem_cache are dereferenced 419 * while freeing the pages, so the kmem_caches should be freed only 420 * after the pending RCU operations are finished. As rcu_barrier() 421 * is a pretty slow operation, we batch all pending destructions 422 * asynchronously. 423 */ 424 mutex_lock(&slab_mutex); 425 list_splice_init(&slab_caches_to_rcu_destroy, &to_destroy); 426 mutex_unlock(&slab_mutex); 427 428 if (list_empty(&to_destroy)) 429 return; 430 431 rcu_barrier(); 432 433 list_for_each_entry_safe(s, s2, &to_destroy, list) { 434 kfence_shutdown_cache(s); 435 #ifdef SLAB_SUPPORTS_SYSFS 436 sysfs_slab_release(s); 437 #else 438 slab_kmem_cache_release(s); 439 #endif 440 #ifdef CONFIG_DEBUG_FS > 441 debugfs_slab_release(s); 442 #endif 443 } 444 } 445 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
