Re: [PATCH v11 06/07] xfs: support CoW in fsdax mode

[Shiyang Ruan]

在 2022/5/10 13:45, Christoph Hellwig 写道:
+#ifdef CONFIG_FS_DAX
+int
+xfs_dax_fault(
+       struct vm_fault         *vmf,
+       enum page_entry_size    pe_size,
+       bool                    write_fault,
+       pfn_t                   *pfn)
+{
+       return dax_iomap_fault(vmf, pe_size, pfn, NULL,
+                       (write_fault && !vmf->cow_page) ?
+                               &xfs_dax_write_iomap_ops :
+                               &xfs_read_iomap_ops);
+}
+#endif

Is there any reason this is in xfs_iomap.c and not xfs_file.c?

Yes, It's better to put it in xfs_file.c since it's the only caller.  I 
didn't notice it...


--
Thanks,
Ruan.


Otherwise the patch looks good:


Reviewed-by: Christoph Hellwig <h...@lst.de>