On Thu, Dec 01, 2022 at 03:32:53PM +0000, Shiyang Ruan wrote:
> Since the basic function for fsdax and reflink has been implemented,
> remove the restrictions of them for widly test.
> 
> Signed-off-by: Shiyang Ruan <ruansy.f...@fujitsu.com>

Looks ok,
Reviewed-by: Darrick J. Wong <djw...@kernel.org>

--D

> ---
>  fs/xfs/xfs_ioctl.c | 4 ----
>  fs/xfs/xfs_iops.c  | 4 ----
>  2 files changed, 8 deletions(-)
> 
> diff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_ioctl.c
> index 1f783e979629..13f1b2add390 100644
> --- a/fs/xfs/xfs_ioctl.c
> +++ b/fs/xfs/xfs_ioctl.c
> @@ -1138,10 +1138,6 @@ xfs_ioctl_setattr_xflags(
>       if ((fa->fsx_xflags & FS_XFLAG_REALTIME) && xfs_is_reflink_inode(ip))
>               ip->i_diflags2 &= ~XFS_DIFLAG2_REFLINK;
>  
> -     /* Don't allow us to set DAX mode for a reflinked file for now. */
> -     if ((fa->fsx_xflags & FS_XFLAG_DAX) && xfs_is_reflink_inode(ip))
> -             return -EINVAL;
> -
>       /* diflags2 only valid for v3 inodes. */
>       i_flags2 = xfs_flags2diflags2(ip, fa->fsx_xflags);
>       if (i_flags2 && !xfs_has_v3inodes(mp))
> diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c
> index 2e10e1c66ad6..bf0495f7a5e1 100644
> --- a/fs/xfs/xfs_iops.c
> +++ b/fs/xfs/xfs_iops.c
> @@ -1185,10 +1185,6 @@ xfs_inode_supports_dax(
>       if (!S_ISREG(VFS_I(ip)->i_mode))
>               return false;
>  
> -     /* Only supported on non-reflinked files. */
> -     if (xfs_is_reflink_inode(ip))
> -             return false;
> -
>       /* Block size must match page size */
>       if (mp->m_sb.sb_blocksize != PAGE_SIZE)
>               return false;
> -- 
> 2.38.1
> 

Reply via email to