Re: [PATCH] nvdimm: make security_show static

[Dave Jiang]

On 6/16/23 09:09, Ben Dooks wrote:

The security_show function is not used outsid of drivers/nvdimm/dimm_devs.c

s/outsid/outside/

and the attribute it is for is also already static. Silence the sparse
warning for this not being declared by making it static. Fixes:

drivers/nvdimm/dimm_devs.c:352:9: warning: symbol 'security_show' was not 
declared. Should it be static?

Signed-off-by: Ben Dooks <ben.do...@codethink.co.uk>

Reviewed-by: Dave Jiang <dave.ji...@intel.com>

---
  drivers/nvdimm/dimm_devs.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/nvdimm/dimm_devs.c b/drivers/nvdimm/dimm_devs.c
index 957f7c3d17ba..1273873582be 100644
--- a/drivers/nvdimm/dimm_devs.c
+++ b/drivers/nvdimm/dimm_devs.c
@@ -349,8 +349,8 @@ static ssize_t available_slots_show(struct device *dev,
  }
  static DEVICE_ATTR_RO(available_slots);

-ssize_t security_show(struct device *dev,

-               struct device_attribute *attr, char *buf)
+static ssize_t security_show(struct device *dev,
+                            struct device_attribute *attr, char *buf)
  {
        struct nvdimm *nvdimm = to_nvdimm(dev);