On 6/29/2023 10:51 PM, Dan Williams wrote: > Michal Wilczynski wrote: >> Currently terminator line contains redunant characters. Remove them and >> also remove a comma at the end. >> >> Signed-off-by: Michal Wilczynski <michal.wilczyn...@intel.com> >> --- >> drivers/acpi/nfit/core.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c >> index aff79cbc2190..95930e9d776c 100644 >> --- a/drivers/acpi/nfit/core.c >> +++ b/drivers/acpi/nfit/core.c >> @@ -3455,7 +3455,7 @@ EXPORT_SYMBOL_GPL(__acpi_nfit_notify); >> >> static const struct acpi_device_id acpi_nfit_ids[] = { >> { "ACPI0012", 0 }, >> - { "", 0 }, >> + {} > Looks like a pointless change to me. It's not very consequential, but isn't totally pointless in my view: "Terminator line is established for the data structure arrays which may have unknown, to the caller, sizes. The purpose of it is to stop iteration over an array and avoid out-of-boundary access. Nevertheless, we may apply a bit more stricter rule to avoid potential, but unlike, event of adding the entry after terminator, already at compile time. This will be achieved by not putting comma at the end of terminator line" Anyway I can drop this change, it's just confusing everyone
- Re: [PATCH v5 07/10] acpi/nfit: Move acpi_nfit_not... Rafael J. Wysocki
- Re: [PATCH v5 07/10] acpi/nfit: Move acpi_nfit... Wilczynski, Michal
- Re: [PATCH v5 07/10] acpi/nfit: Move acpi_... Rafael J. Wysocki
- [PATCH v5 08/10] acpi/nfit: Improve terminator line in ... Michal Wilczynski
- Re: [PATCH v5 08/10] acpi/nfit: Improve terminator... Rafael J. Wysocki
- Re: [PATCH v5 08/10] acpi/nfit: Improve termin... Wilczynski, Michal
- Re: [PATCH v5 08/10] acpi/nfit: Improve te... Rafael J. Wysocki
- Re: [PATCH v5 08/10] acpi/nfit: Improv... Rafael J. Wysocki
- Re: [PATCH v5 08/10] acpi/nfit: I... Wilczynski, Michal
- RE: [PATCH v5 08/10] acpi/nfit: Improve terminator... Dan Williams
- Re: [PATCH v5 08/10] acpi/nfit: Improve termin... Wilczynski, Michal
- [PATCH v5 09/10] acpi/nfit: Move handler installing log... Michal Wilczynski
- Re: [PATCH v5 09/10] acpi/nfit: Move handler insta... Rafael J. Wysocki
- Re: [PATCH v5 09/10] acpi/nfit: Move handler i... Wilczynski, Michal
- Re: [PATCH v5 09/10] acpi/nfit: Move handl... Rafael J. Wysocki
- RE: [PATCH v5 09/10] acpi/nfit: Move handler insta... Dan Williams
- Re: [PATCH v5 09/10] acpi/nfit: Move handler i... Wilczynski, Michal
- Re: [PATCH v5 09/10] acpi/nfit: Move handl... Dan Williams
- Re: [PATCH v5 09/10] acpi/nfit: Move h... Wilczynski, Michal
- [PATCH v5 10/10] acpi/thermal: Move handler installing ... Michal Wilczynski