Hi Vincent,
On Thu, 25 Jan 2024 14:53:40 +0000
Vincent Donnefort <vdonnef...@google.com> wrote:
> > > @@ -1470,12 +1483,20 @@ register_snapshot_trigger(char *glob,
> > > struct event_trigger_data *data,
> > > struct trace_event_file *file)
> > > {
> > > - if (tracing_alloc_snapshot_instance(file->tr) != 0)
> > > + if (tracing_arm_snapshot(file->tr))
> > > return 0;
> >
> > BTW, is this return value correct? It seems that the register_*_trigger()
> > will return error code when it fails.
>
> It should indeed be
>
> ret = tracing_arm_snapshot()
> if (ret)
> return ret;
OK, then there is a bug. We need to fix it before changing this
for backporting.
Thank you,
--
Masami Hiramatsu (Google) <mhira...@kernel.org>
