On 1/29/24 17:16, Alexandru Elisei wrote: > Hi, > > On Mon, Jan 29, 2024 at 02:31:23PM +0530, Anshuman Khandual wrote: >> >> >> On 1/25/24 22:12, Alexandru Elisei wrote: >>> The patch f945116e4e19 ("mm: page_alloc: remove stale CMA guard code") >>> removed the CMA filter when allocating from the MIGRATE_MOVABLE pcp list >>> because CMA is always allowed when __GFP_MOVABLE is set. >>> >>> With the introduction of the arch_alloc_cma() function, the above is not >>> true anymore, so bring back the filter. >> >> This makes sense as arch_alloc_cma() now might prevent ALLOC_CMA being >> assigned to alloc_flags in gfp_to_alloc_flags_cma(). > > Can I add your Reviewed-by tag then? I think all these changes need to be reviewed in their entirety even though some patches do look good on their own. For example this patch depends on whether [PATCH 03/35] is acceptable or not. I would suggest separating out CMA patches which could be debated and merged regardless of this series.
- Re: [PATCH RFC v3 01/35] mm: page_alloc... Alexandru Elisei
- [PATCH RFC v3 02/35] mm: page_alloc: Add an arch hook ea... Alexandru Elisei
- Re: [PATCH RFC v3 02/35] mm: page_alloc: Add an arc... Anshuman Khandual
- Re: [PATCH RFC v3 02/35] mm: page_alloc: Add an... Alexandru Elisei
- [PATCH RFC v3 03/35] mm: page_alloc: Add an arch hook to... Alexandru Elisei
- Re: [PATCH RFC v3 03/35] mm: page_alloc: Add an arc... Anshuman Khandual
- Re: [PATCH RFC v3 03/35] mm: page_alloc: Add an... Alexandru Elisei
- [PATCH RFC v3 04/35] mm: page_alloc: Partially revert &q... Alexandru Elisei
- Re: [PATCH RFC v3 04/35] mm: page_alloc: Partially ... Anshuman Khandual
- Re: [PATCH RFC v3 04/35] mm: page_alloc: Partia... Alexandru Elisei
- Re: [PATCH RFC v3 04/35] mm: page_alloc: Pa... Anshuman Khandual
- Re: [PATCH RFC v3 04/35] mm: page_alloc... Alexandru Elisei
- Re: [PATCH RFC v3 04/35] mm: page_... Anshuman Khandual
- [PATCH RFC v3 05/35] mm: cma: Don't append newline when ... Alexandru Elisei
- Re: [PATCH RFC v3 05/35] mm: cma: Don't append newl... Anshuman Khandual
- Re: [PATCH RFC v3 05/35] mm: cma: Don't append ... Alexandru Elisei
- [PATCH RFC v3 06/35] mm: cma: Make CMA_ALLOC_SUCCESS/FAI... Alexandru Elisei
- Re: [PATCH RFC v3 06/35] mm: cma: Make CMA_ALLOC_SU... Anshuman Khandual
- Re: [PATCH RFC v3 06/35] mm: cma: Make CMA_ALLO... Alexandru Elisei
- Re: [PATCH RFC v3 06/35] mm: cma: Make CMA_... Anshuman Khandual
- Re: [PATCH RFC v3 06/35] mm: cma: Make ... Alexandru Elisei