On Wed, 5 Jun 2024 11:15:38 +0100
Mark Rutland <mark.rutl...@arm.com> wrote:
> > diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
> > index 9dcdefe9d1aa..93c7c5fd4249 100644
> > --- a/kernel/trace/ftrace.c
> > +++ b/kernel/trace/ftrace.c
> > @@ -1701,8 +1701,20 @@ static bool skip_record(struct dyn_ftrace *rec)
> > !(rec->flags & FTRACE_FL_ENABLED);
> > }
> >
> > +/*
> > + * This is the main engine to the ftrace updates.
> > + *
> > + * It will iterate through all the available ftrace functions
> > + * (the ones that ftrace can have callbacks to) and set the flags
> > + * to the associated dyn_ftrace records.
>
> I beleive s/to/in/ here, to make this one of:
>
> set the flags in the associated dyn_ftrace records.
>
> ... rather than:
>
> set the flags to the associated dyn_ftrace records.
Thanks. It's good to get a "native English speaker" response ;-)
>
> > + *
> > + * @filter_hash: True if for the filter hash is udpated, false for the
> > + * notrace hash
>
> Typo: s/udpated/updated/
>
> ... though I couldn't parse this regardless; maybe:
>
> @filter_hash: true to update the filter hash, false to update
> the notrace hash
Sure.
-- Steve
>
> Mark.
>
> > + * @inc: True to add this hash, false to remove it (increment the
> > + * recorder counters or decrement them).
> > + */
> > static bool __ftrace_hash_rec_update(struct ftrace_ops *ops,
> > - int filter_hash,
> > + bool filter_hash,
> > bool inc)
> > {
> > struct ftrace_hash *hash;
> > --
> > 2.43.0
> >
> >
