On Wed, Jun 26, 2024 at 08:20:13PM +0200, Borislav Petkov wrote:
> On Wed, Jun 26, 2024 at 01:00:30PM -0500, Naik, Avadhut wrote:
> > >
> > > Why are you clearing it if you're overwriting it immediately?
> > >
> > Since its a local variable, wanted to ensure that the memory is zeroed out
> > to prevent
> > any issues with the %s specifier, used later on.
>
> What issues?
>
> > Would you recommend removing that and using initializer instead for the
> > string?
>
> I'd recommend looking at what the code does and then really thinking whether
> that makes any sense.
>
We need to make sure the string is NULL-terminated. So the memset()
could be replaced with this:
frutext[16] = '\0';
Or better yet, maybe we can use scnprintf() or similar.
Thanks,
Yazen
