Hi Andrew,
> From: Andrew Lunn <and...@lunn.ch>
> Sent: Tuesday, July 9, 2024 12:31 AM
> To: Cindy Lu <l...@redhat.com>
> Cc: Dragos Tatulea <dtatu...@nvidia.com>; m...@redhat.com;
> jasow...@redhat.com; Parav Pandit <pa...@nvidia.com>;
> sgarz...@redhat.com; net...@vger.kernel.org; virtualization@lists.linux-
> foundation.org; linux-kernel@vger.kernel.org; k...@vger.kernel.org
> Subject: Re: [PATCH] vdpa/mlx5: Add the support of set mac address
>
> On Mon, Jul 08, 2024 at 02:55:49PM +0800, Cindy Lu wrote:
> > Add the function to support setting the MAC address.
> > For vdpa/mlx5, the function will use mlx5_mpfs_add_mac to set the mac
> > address
> >
> > Tested in ConnectX-6 Dx device
> >
> > Signed-off-by: Cindy Lu <l...@redhat.com>
> > ---
> > drivers/vdpa/mlx5/net/mlx5_vnet.c | 23 +++++++++++++++++++++++
> > 1 file changed, 23 insertions(+)
> >
> > diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > index 26ba7da6b410..f78701386690 100644
> > --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > @@ -3616,10 +3616,33 @@ static void mlx5_vdpa_dev_del(struct
> vdpa_mgmt_dev *v_mdev, struct vdpa_device *
> > destroy_workqueue(wq);
> > mgtdev->ndev = NULL;
> > }
> > +static int mlx5_vdpa_set_attr_mac(struct vdpa_mgmt_dev *v_mdev,
> > + struct vdpa_device *dev,
> > + const struct vdpa_dev_set_config
> *add_config) {
> > + struct mlx5_vdpa_dev *mvdev = to_mvdev(dev);
> > + struct mlx5_vdpa_net *ndev = to_mlx5_vdpa_ndev(mvdev);
> > + struct mlx5_core_dev *mdev = mvdev->mdev;
> > + struct virtio_net_config *config = &ndev->config;
> > + int err;
> > + struct mlx5_core_dev *pfmdev;
> > +
> > + if (add_config->mask & (1 <<
> VDPA_ATTR_DEV_NET_CFG_MACADDR)) {
> > + if (!is_zero_ether_addr(add_config->net.mac)) {
>
> Is the core happy to call into the driver without validating the MAC address?
> Will the core pass the broadcast address? That is not zero. Or a multicast
> address? Should every driver repeat the same validation, and probably get it
> just as wrong?
>
> Andrew
>
I will submit the patch to add the check in the vdpa core for mac address
validation.
> ---
> pw-bot: cr
