On 07/10, Andrii Nakryiko wrote:
>
> LGTM with few nits below.
>
> Acked-by: Andrii Nakryiko <and...@kernel.org>
Thanks for looking at this.
> > @@ -3477,7 +3477,7 @@ int bpf_uprobe_multi_link_attach(const union bpf_attr
> > *attr, struct bpf_prog *pr
> > &bpf_uprobe_multi_link_lops, prog);
> >
> > for (i = 0; i < cnt; i++) {
> > - err =
> > uprobe_register_refctr(d_real_inode(link->path.dentry),
> > + err = uprobe_register(d_real_inode(link->path.dentry),
> > uprobes[i].offset,
> > uprobes[i].ref_ctr_offset,
> > &uprobes[i].consumer);
>
> please adjust indentation here
OK,
> > - if (tu->ref_ctr_offset)
> > - ret = uprobe_register_refctr(tu->inode, tu->offset,
> > - tu->ref_ctr_offset, &tu->consumer);
> > - else
> > - ret = uprobe_register(tu->inode, tu->offset, &tu->consumer);
> > -
> > + ret = uprobe_register(tu->inode, tu->offset, tu->ref_ctr_offset,
> > + &tu->consumer);
>
> doesn't fit under 100 characters? If it does, please keep as a single line.
OK, will do.
Oleg.
