út 13. 8. 2024 v 13:49 odesílatel Eder Zulian <[email protected]> napsal:
>
> In addition, fix a typo in the error message generated when the
> specified duration is invalid.
>
> Signed-off-by: Eder Zulian <[email protected]>
> ---
> tools/tracing/rtla/src/osnoise_hist.c | 4 ++--
> tools/tracing/rtla/src/timerlat_hist.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
FYI some of the issues you fixed for hist are also in timerlat_top.c:
" -d/--duration time[m|h|d]: duration of the session in seconds",
...
case 'd':
params->duration = parse_seconds_duration(optarg);
if (!params->duration)
timerlat_top_usage("Invalid -D duration\n");
break;
and the "Invalid -D duration" (instead of "-d") one is also in
osnoise_top.c. Those would probably go to a separate patch, though.
Reviewed-by: Tomas Glozar <[email protected]>
Tomas
