On Sun, 25 Aug 2024, zhang warden wrote:

> >> 1. Move klp_ops into klp_func structure.
> >> Rewrite the logic of klp_find_ops and
> >> other logic to get klp_ops of a function.
> >> 
> >> 2. Move definition of struct klp_ops into
> >> include/linux/livepatch.h
> > 
> > Why?
> > 
> 
> Hi, Christoph.
> 
> When introducing feature of "using", we should handle the klp_ops check.
> In order to get klp_ops from transition, we may have more complex logic for 
> checking.
> 
> If we move klp_ops into klp_func. We can remove the global list head of 
> klp_ops.
> What's more, there are some code in livepatch should get function's ops.
> With this feature, we don't need the original search to the one ops.
> It can be simple and straightforward.

I believe that Christoph's "Why?" in fact meant "please include the 
rationale for the changes being made (such as the above) in the patch 
changelog" :)

Thanks,

-- 
Jiri Kosina
SUSE Labs


Reply via email to