Use dev_err_probe() to make error and defer code handling simpler.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlow...@linaro.org>
---
 drivers/remoteproc/qcom_q6v5_pas.c | 22 +++++++---------------
 1 file changed, 7 insertions(+), 15 deletions(-)

diff --git a/drivers/remoteproc/qcom_q6v5_pas.c 
b/drivers/remoteproc/qcom_q6v5_pas.c
index 
ef82835e98a4efd4bc603cff604d531a51fe9f9c..806b3baa297ea1053dde3343fd86cffbc05b8461
 100644
--- a/drivers/remoteproc/qcom_q6v5_pas.c
+++ b/drivers/remoteproc/qcom_q6v5_pas.c
@@ -453,24 +453,16 @@ static const struct rproc_ops adsp_minidump_ops = {
 
 static int adsp_init_clock(struct qcom_adsp *adsp)
 {
-       int ret;
-
        adsp->xo = devm_clk_get(adsp->dev, "xo");
-       if (IS_ERR(adsp->xo)) {
-               ret = PTR_ERR(adsp->xo);
-               if (ret != -EPROBE_DEFER)
-                       dev_err(adsp->dev, "failed to get xo clock");
-               return ret;
-       }
+       if (IS_ERR(adsp->xo))
+               return dev_err_probe(adsp->dev, PTR_ERR(adsp->xo),
+                                    "failed to get xo clock");
+
 
        adsp->aggre2_clk = devm_clk_get_optional(adsp->dev, "aggre2");
-       if (IS_ERR(adsp->aggre2_clk)) {
-               ret = PTR_ERR(adsp->aggre2_clk);
-               if (ret != -EPROBE_DEFER)
-                       dev_err(adsp->dev,
-                               "failed to get aggre2 clock");
-               return ret;
-       }
+       if (IS_ERR(adsp->aggre2_clk))
+               return dev_err_probe(adsp->dev, PTR_ERR(adsp->aggre2_clk),
+                                    "failed to get aggre2 clock");
 
        return 0;
 }

-- 
2.43.0


Reply via email to