On Fri, Nov 1, 2024 at 10:38 PM Boqun Feng <boqun.f...@gmail.com> wrote: > > but this lint doesn't make sense to me, I would say we just drop this > lint?
I am not sure if it is intended to fire there (i.e. to resolve constants), but seems OK since it is not something one would want normally to write except in exceptional cases. So we could drop it globally, but if it is just this case that we expect, then I think it is better to just `#[expect(...)]` it (or perhaps use a different example) and then, if we see in the future that we have quite a few "trivial" comparisons like this, then we can drop it globally. Cheers, Miguel
