From: Cong Liu <[email protected]>

Fix a bug where the code was checking the wrong file descriptors
when opening the input files. The code was checking 'fd' instead
of 'fd_in', which could lead to incorrect error handling.

Fixes: 05be5e273c84 ("selftests: mptcp: add disconnect tests")
Cc: [email protected]
Fixes: ca7ae8916043 ("selftests: mptcp: mptfo Initiator/Listener")
Co-developed-by: Geliang Tang <[email protected]>
Signed-off-by: Geliang Tang <[email protected]>
Signed-off-by: Cong Liu <[email protected]>
Reviewed-by: Matthieu Baerts (NGI0) <[email protected]>
Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
---
 tools/testing/selftests/net/mptcp/mptcp_connect.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/net/mptcp/mptcp_connect.c 
b/tools/testing/selftests/net/mptcp/mptcp_connect.c
index 
d240d02fa443a1cd802f0e705ab36db5c22063a8..893dc36b12f607bec56a41c9961eff272a7837c7
 100644
--- a/tools/testing/selftests/net/mptcp/mptcp_connect.c
+++ b/tools/testing/selftests/net/mptcp/mptcp_connect.c
@@ -1270,7 +1270,7 @@ int main_loop(void)
 
        if (cfg_input && cfg_sockopt_types.mptfo) {
                fd_in = open(cfg_input, O_RDONLY);
-               if (fd < 0)
+               if (fd_in < 0)
                        xerror("can't open %s:%d", cfg_input, errno);
        }
 
@@ -1293,7 +1293,7 @@ int main_loop(void)
 
        if (cfg_input && !cfg_sockopt_types.mptfo) {
                fd_in = open(cfg_input, O_RDONLY);
-               if (fd < 0)
+               if (fd_in < 0)
                        xerror("can't open %s:%d", cfg_input, errno);
        }
 

-- 
2.48.1


Reply via email to