On Fri Mar 21, 2025 at 4:55 PM CET, Dmitry Baryshkov wrote: > On Fri, Mar 21, 2025 at 03:45:00PM +0100, Luca Weiss wrote: >> From: Konrad Dybcio <[email protected]> >> >> Add support for the video clock controller found on SM6350 based >> devices. >> >> Signed-off-by: Konrad Dybcio <[email protected]> >> Co-developed-by: Luca Weiss <[email protected]> >> Signed-off-by: Luca Weiss <[email protected]> >> --- >> drivers/clk/qcom/Kconfig | 9 + >> drivers/clk/qcom/Makefile | 1 + >> drivers/clk/qcom/videocc-sm6350.c | 355 >> ++++++++++++++++++++++++++++++++++++++ >> 3 files changed, 365 insertions(+) >> >> + >> +/* 600 MHz */ >> +static const struct alpha_pll_config video_pll0_config = { >> + .l = 0x1F, > > Nit: lowercase hex please. No need to repost just for the sake of this > single line.
Sounds like there'll be a v2 anyways with dts changes, so I'll fix it! Regards Luca > > Reviewed-by: Dmitry Baryshkov <[email protected]> > > >> + .alpha = 0x4000, >> + .config_ctl_val = 0x20485699, >> + .config_ctl_hi_val = 0x00002067, >> + .test_ctl_val = 0x40000000, >> + .test_ctl_hi_val = 0x00000002, >> + .user_ctl_val = 0x00000101, >> + .user_ctl_hi_val = 0x00004005, >> +}; >> + >>
