Hello Bjorn, Gentle reminder.
For your information, I proposed to Mathieu that he wait for your first review, as this revision is intended to address your comments on revision 15." Thanks, Arnaud On 3/25/25 10:58, Arnaud Pouliquen wrote: > Main updates from version V15[1]: > - Removed the rproc_ops:load_fw() operation introduced in the previous > version. > - Returned to managing the remoteproc firmware loading in rproc_tee_parse_fw > to > load and authenticate the firmware before getting the resource table. > - Added spinlock and dev_link mechanisms in remoteproc TEE to better manage > bind/unbind. > > More details are available in each patch commit message. > > [1] > https://lore.kernel.org/linux-remoteproc/20241128084219.2159197-7-arnaud.pouliq...@foss.st.com/T/ > > Tested-on: commit 0a0ba9924445 ("Linux 6.14-rc7") > > Description of the feature: > -------------------------- > This series proposes the implementation of a remoteproc tee driver to > communicate with a TEE trusted application responsible for authenticating > and loading the remoteproc firmware image in an Arm secure context. > > 1) Principle: > > The remoteproc tee driver provides services to communicate with the OP-TEE > trusted application running on the Trusted Execution Context (TEE). > The trusted application in TEE manages the remote processor lifecycle: > > - authenticating and loading firmware images, > - isolating and securing the remote processor memories, > - supporting multi-firmware (e.g., TF-M + Zephyr on a Cortex-M33), > - managing the start and stop of the firmware by the TEE. > > 2) Format of the signed image: > > Refer to: > https://github.com/OP-TEE/optee_os/blob/master/ta/remoteproc/src/remoteproc_core.c#L18-L57 > > 3) OP-TEE trusted application API: > > Refer to: > https://github.com/OP-TEE/optee_os/blob/master/ta/remoteproc/include/ta_remoteproc.h > > 4) OP-TEE signature script > > Refer to: > https://github.com/OP-TEE/optee_os/blob/master/scripts/sign_rproc_fw.py > > Example of usage: > sign_rproc_fw.py --in <fw1.elf> --in <fw2.elf> --out <signed_fw.sign> --key > ${OP-TEE_PATH}/keys/default.pem > > > 5) Impact on User space Application > > No sysfs impact. The user only needs to provide the signed firmware image > instead of the ELF image. > > > For more information about the implementation, a presentation is available > here > (note that the format of the signed image has evolved between the presentation > and the integration in OP-TEE). > > https://resources.linaro.org/en/resource/6c5bGvZwUAjX56fvxthxds > > > > Arnaud Pouliquen (6): > remoteproc: core: Introduce rproc_pa_to_va helper > remoteproc: Add TEE support > remoteproc: Introduce release_fw optional operation > dt-bindings: remoteproc: Add compatibility for TEE support > remoteproc: stm32: Create sub-functions to request shutdown and > release > remoteproc: stm32: Add support of an OP-TEE TA to load the firmware > > .../bindings/remoteproc/st,stm32-rproc.yaml | 58 +- > drivers/remoteproc/Kconfig | 10 + > drivers/remoteproc/Makefile | 1 + > drivers/remoteproc/remoteproc_core.c | 52 ++ > drivers/remoteproc/remoteproc_internal.h | 6 + > drivers/remoteproc/remoteproc_tee.c | 619 ++++++++++++++++++ > drivers/remoteproc/stm32_rproc.c | 139 +++- > include/linux/remoteproc.h | 4 + > include/linux/remoteproc_tee.h | 90 +++ > 9 files changed, 935 insertions(+), 44 deletions(-) > create mode 100644 drivers/remoteproc/remoteproc_tee.c > create mode 100644 include/linux/remoteproc_tee.h > > > base-commit: 0a0ba99244455fea8706c4a53f5f66a45d87905d
