On Fri, Apr 18, 2025 at 06:04:29PM +0530, Sahil Siddiq wrote: > Hi, > > On 4/18/25 3:30 PM, Stafford Horne wrote: > > On Fri, Apr 18, 2025 at 02:42:20PM +0530, Sahil Siddiq wrote: > > > On 4/18/25 1:17 PM, Stafford Horne wrote: > > > > On Fri, Apr 04, 2025 at 10:39:22AM +0530, Sahil Siddiq wrote: > > > > [...] > > > > I was working on getting this patches ready for upstreaming and noticed > > > > one > > > > thing: > > > > > > > > > > > > --------------------------------------------------------------------------------------- > > > > > > > > ./patches/or1k-20250418/0001-openrisc-Refactor-struct-cpuinfo_or1k-to-reduce-dupl.patch > > > > > > > > --------------------------------------------------------------------------------------- > > > > WARNING: From:/Signed-off-by: email address mismatch: 'From: > > > > Sahil Siddiq <[email protected]>' != 'Signed-off-by: Sahil Siddiq > > > > <[email protected]>' > > > > > > > > total: 0 errors, 1 warnings, 102 lines checked > > > > > > > > As you can see above the scripts/checkpatch.pl is failing with the > > > > warning > > > > about your email and signed-off-by not matching. You can see more > > > > about it > > > > in the FROM_SIGN_OFF_MISMATCH section of the checkpatch[0] docs. > > > > > > Ok, this makes sense. I configured git-send-email to use gmail because > > > protonmail does not work with git-send-email without a paid account. > > > > > > > How would you like to resolve this? > > > > > > Is this a warning that cannot be ignored? I can: > > > > > > 1. submit the patch series with another email address that won't have > > > issues > > > with git-send-email, or > > > 2. submit the patch series using protonmail's web client (which might not > > > be > > > the best option). > > > > > > I would prefer not to use "icegambit91" in the signed-off-by tag. > > > > > > What are your thoughts on this? > > > > I could rewrite the from header to match [email protected]. > > > > But if I do that you should find a way to get proton.me to work with > > gi-send-email [0] for future commits. It seems this can work using the > > Protonmail Bridge[1], though this site also says proton.me is not so good > > for > > using with git send email. > > Right. Also, protonmail bridge requires a paid proton account. > > > Maybe using another email in signed-off-by would be better. The current > > patches are on linux-next[2] where we can see the From/Signed-off-by > > mismatch. > > For example: > > > > author Sahil Siddiq <[email protected]> 2025-03-29 15:16:22 > > +0530 > > committer Stafford Horne <[email protected]> 2025-03-29 > > 10:22:21 +0000 > > commit af83ece87a1ef5097434b7c3c1fc0e9e7b83b192 (patch) > > > > ... > > > > Signed-off-by: Sahil Siddiq <[email protected]> > > Signed-off-by: Stafford Horne <[email protected]> > > > > I agree. I have another email id ([email protected]). I can configure git > to use this and this can also be used in the signed-off-by tag. So, this id > shouldn't cause an issue. > > Let me know if I should send the series using this email id.
Yes, please do this. -Stafford
