On Thu, 1 May 2025 at 09:43, Luis Gerhorst <[email protected]> wrote:
>
> This is required to catch the errors later and fall back to a nospec if
> on a speculative path.
>
> Eliminate the regs variable as it is only used once and insn_idx is not
> modified in-between the definition and usage.
>
> Still pass insn simply to match the other check_*() functions. As Eduard
> points out [1], insn is assumed to correspond to env->insn_idx in many
> places (e.g, __check_reg_arg()).
>
> Move code into do_check_insn(), replace
> * "continue" with "return 0" after modifying insn_idx
> * "goto process_bpf_exit" with "return PROCESS_BPF_EXIT"
> * "do_print_state = " with "*do_print_state = "
>
> [1] 
> https://lore.kernel.org/all/[email protected]/
>
> Signed-off-by: Luis Gerhorst <[email protected]>
> Acked-by: Henriette Herzog <[email protected]>
> Cc: Maximilian Ott <[email protected]>
> Cc: Milan Stephan <[email protected]>
> ---

Acked-by: Kumar Kartikeya Dwivedi <[email protected]>

Reply via email to