Hi Peng, On Tue, May 06, 2025 at 12:46:18PM +0800, Peng Fan wrote: > On Mon, May 05, 2025 at 12:48:48PM -0300, Hiago De Franco wrote: > >From: Hiago De Franco <hiago.fra...@toradex.com> > > > >Move imx_sc_get_pd_power() from pmdomain/imx/scu-pd.c to > >firmware/imx/misc.c and rename it to imx_sc_pm_get_resource_power_mode() > >to maintain the same naming logic with other functions in misc.c. > > > >This makes the API available for other use cases. For example, > >remoteproc/imx_rproc.c can now use this function to check the power mode > >of the remote core. > > Better put this patch at the first I think.
Ok, I will do that. > > To be simple, I think just export > imx_sc_get_pd_power in drivers/pmdomain/imx/scu-pd.c. > And add the function declaration in include/linux/firmware/imx/sci.h. I do not think this is correct, since it is specific to the scu-pd.c driver and none of the functions there are exported. I believe the correct implementation is moving to misc.c and export it there, just like the other SCU API functions. I will send a v2 today with the comments adressed, thanks. > > Not sure Ulf or Shawn is good with it. > > Regards, > Peng > Cheers, Hiago.
