On Fri, May 9, 2025 at 5:24 AM Saket Kumar Bhaskar <[email protected]> wrote: > > On linux-next, build for bpf selftest displays an error due to > mismatch in the expected function signature of bpf_testmod_test_read > and bpf_testmod_test_write. > > Commit 97d06802d10a ("sysfs: constify bin_attribute argument of > bin_attribute::read/write()") > changed the required type for struct bin_attribute to const struct > bin_attribute. > > To resolve the error, update corresponding signature for the callback. > > Reported-by: Venkat Rao Bagalkote <[email protected]> > Closes: > https://lore.kernel.org/all/[email protected]/ > Signed-off-by: Saket Kumar Bhaskar <[email protected]> > --- > tools/testing/selftests/bpf/test_kmods/bpf_testmod.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/bpf/test_kmods/bpf_testmod.c > b/tools/testing/selftests/bpf/test_kmods/bpf_testmod.c > index 2e54b95ad898..194c442580ee 100644 > --- a/tools/testing/selftests/bpf/test_kmods/bpf_testmod.c > +++ b/tools/testing/selftests/bpf/test_kmods/bpf_testmod.c > @@ -385,7 +385,7 @@ int bpf_testmod_fentry_ok; > > noinline ssize_t > bpf_testmod_test_read(struct file *file, struct kobject *kobj, > - struct bin_attribute *bin_attr, > + const struct bin_attribute *bin_attr, > char *buf, loff_t off, size_t len)
You didn't even compile it :( Instead of fixing the build, it breaks the build. pw-bot: cr
