Hi Mark, Thanks for your review and the fixups!
On Mon, May 19, 2025 at 6:41 AM Mark Rutland <mark.rutl...@arm.com> wrote: > [...] > > ... and then in future we can add anything spdecific to reliable > stacktrace there. > > That aside, this generally looks good to me. The only thing that I note > is that we're lacking a check on the return value of > kretprobe_find_ret_addr(), and we should return -EINVAL when that is > NULL, but that should never happen in normal operation. > > I've pushed a arm64/stacktrace-updates branch [1] with fixups for those > as two separate commits atop this one. If that looks good to you I > suggest we post that as a series and ask Will and Catalin to take that > as-is. > > I'll look at the actual patching bits now. > > Mark. > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/mark/linux.git/ > arm64/stacktrace-updates For the fixups: Reviewed-and-tested-by: Song Liu <s...@kernel.org> Tested with 2/2 of this set and samples/livepatch. Song
