On Tue May 27, 2025 at 11:09 AM CEST, Xu Kuohai wrote: > On 5/27/2025 4:45 PM, Alexis Lothoré wrote: > > [...] > >>>> + /* We can not know for sure about exact alignment needs for >>>> + * struct passed on stack, so deny those >>>> + */ >>>> + if (m->arg_flags[i] & BTF_FMODEL_STRUCT_ARG) >>>> + return -EOPNOTSUPP; >>> leave the error code as is, namely, return -ENOTSUPP? >> Actually this change follows a complaint from checkpatch: >> >> "WARNING: ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP" > > Seems we can just ignore this warning, as ENOTSUPP is already used > throughout bpf, and the actual value -524 is well recognized.
Ok, then I'll switch it back to ENOTSUPP -- Alexis Lothoré, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
