Check if "procmap_out->fd" is negative instead of "procmap_out" (which
is a pointer).

Fixes: bd23f293a0d5 ("tools/testing: add PROCMAP_QUERY helper functions in mm 
self tests")
Signed-off-by: Dan Carpenter <dan.carpen...@linaro.org>
---
 tools/testing/selftests/mm/vm_util.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/mm/vm_util.c 
b/tools/testing/selftests/mm/vm_util.c
index 1357e2d6a7b6..61d7bf1f8c62 100644
--- a/tools/testing/selftests/mm/vm_util.c
+++ b/tools/testing/selftests/mm/vm_util.c
@@ -439,7 +439,7 @@ int open_procmap(pid_t pid, struct procmap_fd *procmap_out)
        sprintf(path, "/proc/%d/maps", pid);
        procmap_out->query.size = sizeof(procmap_out->query);
        procmap_out->fd = open(path, O_RDONLY);
-       if (procmap_out < 0)
+       if (procmap_out->fd < 0)
                ret = -errno;
 
        return ret;
-- 
2.47.2


Reply via email to