On 5/25/25 12:26, Harshal Wadhwa wrote:
On Fri, 23 May 2025 at 03:49, Shuah Khan <sk...@linuxfoundation.org> wrote:
On 5/16/25 09:39, Harshal wrote:
Specify details in logs of failed cases
Use die() instead of exit() when write to
sys_path fails
Please explain why this change is needed?
Signed-off-by: Harshal <embedkari...@gmail.com>
---
tools/testing/selftests/firmware/fw_namespace.c | 17 +++++++++--------
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/tools/testing/selftests/firmware/fw_namespace.c
b/tools/testing/selftests/firmware/fw_namespace.c
index 04757dc7e546..deff7f57b694 100644
--- a/tools/testing/selftests/firmware/fw_namespace.c
+++ b/tools/testing/selftests/firmware/fw_namespace.c
@@ -38,10 +38,11 @@ static void trigger_fw(const char *fw_name, const char
*sys_path)
fd = open(sys_path, O_WRONLY);
if (fd < 0)
- die("open failed: %s\n",
+ die("open of sys_path failed: %s\n",
strerror(errno));
if (write(fd, fw_name, strlen(fw_name)) != strlen(fw_name))
- exit(EXIT_FAILURE);
+ die("write to sys_path failed: %s\n",
+ strerror(errno));
Hmm. Wrapper scripts key off of the EXIT_FAILURE - how does
the output change with this change?
In the whole test file, all fail cases uses die() with the specified
error log and error code, so just wanted to add a error log for this
fault condition and maintain consistency.
You don't want to make changes to be consistent, especially when
the change alters the behavior - this change changes the results.
thanks,
-- Shuah
