On Wed, Jun 04, 2025 at 02:26:57PM +0200, Oscar Salvador wrote: > On Wed, Jun 04, 2025 at 10:09:05AM +0100, Lorenzo Stoakes wrote: > > Nice idea to move to mm/internal.h also :) I like this... > > > > Will fixup on respin > > Dumb question but IIUC, walk_page_range_novma() will only be used by > ptdump from now on, so why not stick it into mm/ptdump.c, which is where > the only user of it lives?
There's no such thing as a dumb question :) Even though I have maybe tested that concept in the past personally ;) I think mm/internal.h is fine, would be weird to have the declaration in mm/ptdump.c but implemented elsewhere and obviously we need to keep the page walking stuff together. So I think it is best to keep it in internal.h > > -- > Oscar Salvador > SUSE Labs
