On 2025-06-02 11:04:50, Jiayuan Chen wrote: > 2025/5/30 02:16, "Cong Wang" <xiyou.wangc...@gmail.com> 写到: > > > > > On Fri, May 23, 2025 at 09:18:58PM +0800, Jiayuan Chen wrote: > >
[...] > > > > I am wondering if we need to WARN here? Because the code below this > > > > handles it gracefully: > > > > Hi Cong > > The ctx->open_rec is freed after a TLS record is processed (regardless > of whether the redirect check passes or triggers a redirect). > The 'if (rec)' check in the subsequent code you print is indeed designed > to handle the expected lifecycle state of open_rec. > > But the code path I modified should never see a NULL open_rec under normal > operation As this is a bug fix, I need to ensure the fix itself doesn't > create new issues. > > Thanks. If we never see the NULL lets just drop the WARN. In general we prefer not to scatter warns everywhere. Can you resubmit without it? Thanks! John
