On 05.06.25 19:19, Mark Brown wrote:
On Thu, Jun 05, 2025 at 06:55:53PM +0200, David Hildenbrand wrote:
On 05.06.25 18:42, Mark Brown wrote:
I can't remember off hand, sorry.
I assume in ... my review to patch #4?
Oh, yeah - it's there. I did look there but the "not a fan" bit made me
think it was one of the stylistic things as I quickly scanned through.
What an unpleasant upstream experience.
TBH this has been a lot better than the more common failure mode with
working on selftests where people just completely ignore or are openly
dismissive about them :/ . Probably room for a middle ground though.
Can we *please* limit such reworks to mechanical changes in the future?
It's just absolutely hard to spot these things during review (I did at
least on patch #4).
And Andrew apparently just merges them -- and I am left with the feeling
that we create more mess by "accident".
Anyhow, thanks for working on these tests ...
--
Cheers,
David / dhildenb
